Please remove private declaration from testImpl in class AnyFunSuiteLike

Libraries
1

There is a method testImpl which has the same behavior as the test method had in scala 2.13, but it is unfortunately marked private so I cannot call it from my subclass of AnyFunSuite.

How can I request that either this private decoration be removed, or a public method be installed which simply calls testImpl passing the arguments along?

The fact that his behavior has changed in scala 3.x is making it difficult to convert a project from 2.13 to 3.x.

Here is the code I’d like to make compile and run in scala 3.x.
I declare a subclass AdjFunSuite which overrides the test method and calls super.test(...)(...)(...).

This worked fine in scala 2.13 but in 3.x the test method is inlined and simply calls testImpl.

In my opinion either the inline should be removed, or another method should be provided so a method in an application class can call it.

2

(post deleted by author)

3 
package adjuvant
import org.scalatest.funsuite.AnyFunSuite


class AdjFunSuite extends AnyFunSuite {
  import org.scalactic.source
  import org.scalatest.Tag

  val num_random_tests:Int = sys.env.get("CI_REGISTRY_IMAGE") match {
    case None => 1000   // if interactive
    case Some(_) => 100 // if in ci/cd pipeline
  }

  override def test(testName: String, testTags: Tag*)(testFun: => Any /* Assertion */)(implicit pos: source.Position):Unit = {
    super.test(testName,testTags*)(locally{
      import java.time.{Duration, LocalDateTime}
      val start = LocalDateTime.now()
      println("[ starting " + testName
                + " at : " + start
                + " total time: " + AdjFunSuite.elapsed())
      var finished = false
      try{
        testFun
        finished = true
      }
      finally {
        val endLocalTime = LocalDateTime.now()
        val status = if (finished) "finished" else "aborted"
        println(s"] ${status} "
                  + testName
                  + " at : " + endLocalTime
                  + " test time: " + Duration.between(start, endLocalTime)
                  + " total time: " + AdjFunSuite.elapsed())
      }
    })(pos)
  }
}

object AdjFunSuite {

  import java.time.{Duration, LocalDateTime}
  val testsStartedTime: LocalDateTime = LocalDateTime.now()

  def elapsed():Duration = Duration.between(testsStartedTime, LocalDateTime.now())
}
4

I tried to get around this by copying the AnyTestSuiteLike definition locally and removing the private decoration, but this won’t make AnyTestSuite inherit from my version of AnyTestSuiteLike. I abandoned this, but I could, I suppose, also make a local copy of AnyTestSuite. But this just seems like the wrong solution.

I would also be happy if someone could suggest how to implement a function xtest which simply calls test. The problem is that since test is inlined, it gets the line number from that inlined call-site and passes that line number to testImpl. This would be horrible, because every test would get the exact same line number position, i.e., the one from the call to test inside AdjFunSuite. What we’d like is the line number position from the actual line doing the testing, i.e., the call site of xtest. But I don’t see a way to pass along the line number position to a method in AnyFunSuite because all the methods which accept the position seem to be private.

5

@bvenners ^

6

I had a conversation with chatGPT and he suggested I could call the method “testImpl” programmatically using reflection. After a few iterations with chatGPT, here is the code I came up with. It finds the method and overrides the private flag and calls the method anyway.

Note that I’m using def test not override def test because test is not an inherited method.

7 

  def test(testName: String, testTags: Tag*)(testFun: => Any /* Assertion */)(implicit pos: source.Position):Unit = {
    val testImpl = classOf[org.scalatest.funsuite.AnyFunSuiteLike]
      .getDeclaredMethods
      .find(m => m.getName.contains("testImpl") && m.getParameterCount == 4)
      .get

    def wrapper():Any = {
      import java.time.{Duration, LocalDateTime}
      val start = LocalDateTime.now()
      println("[ starting " + testName
                + " at : " + start
                + " total time: " + AdjFunSuite.elapsed())
      var finished = false
      try{
        testFun
        finished = true
      }
      finally {
        val endLocalTime = LocalDateTime.now()
        val status = if (finished) "finished" else "aborted"
        println(s"] ${status} "
                  + testName
                  + " at : " + endLocalTime
                  + " test time: " + Duration.between(start, endLocalTime)
                  + " total time: " + AdjFunSuite.elapsed())
      }
    }
    testImpl.setAccessible(true)
    testImpl.invoke(this, testName, testTags, () => wrapper(), pos)
  }
8

I’ve created a permalink to GitHub here I have what seems to be a working version, using the java reflection API: ….setAccessible(true)

permalink to application-specific test method